Add support for tags to blog posts #503
Conversation
rauhul
requested review from
cthielen,
TimTr,
tkremenek,
tomerd,
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
mschinis and
shahmishal
as code owners
|
I tried to do this with a new |
|
related to #98 |
|
@swift-ci please test |
|
@shahmishal can I get a review on this? |
|
The website workgroup discussed this topic last week, and it's a great idea. The next steps:
@dempseyatgithub had previously worked on identifying each blog post; he was planning on digging up old notes. |
I think it would be good to handle this in a subsequent PR, I'm not a web dev and It might take me (or anyone else) some time to implement that feature. I think the tags have value without having search immediately |
Adds simple tag bubbles that can be added to blog posts. In the future we may want to make these selectable for filtering and include a search bar as was done for swift-evolution.
| flex-direction: row; | ||
| /* Allow tags to wrap to additional lines */ | ||
| flex-wrap: wrap; | ||
| /* Add a small gap between additional lines */ | ||
| gap: 0.4em; | ||
| /* Align to trailing edge */ | ||
| justify-content: flex-end; |
There was a problem hiding this comment.
I think we can remove these comments as they do not add additional insight that the styles aren't already telling.
There was a problem hiding this comment.
We also need to add a media query to improve the mobile layout. My vote would be to put the tags below the date label to accommodate larger accessibility font sizes.
There was a problem hiding this comment.
@rauhul If you want I can push these changes after getting this merged to unblock this.
There was a problem hiding this comment.
Sure! I dont think I'll have time for a while to address these css changes.
Excuse the crude markup, but I was hoping on laying out the tags like this:
|
Let's revisit this as part of the next version of the site that is currently underway. |
Adds simple tag bubbles that can be added to blog posts. In the future we may want to make these selectable for filtering and include a search bar as was done for swift-evolution.
Before:
After:
