Split test skip conditionals up by responsibility #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static functions on the `SkipUnless` utility are used to skip XCTests unless some condition is met. Each of these methods effectively do two things: 1) Check if the condition is met 2) If not, skip the test using `XCTSkip` To facilitate the adoption of swift-testing these feature conditions need to be able to be checked without involving XCTest methods. Break out the feature detection in to `TestFeature`, and have the methods on `SkipUnless` call these methods and then perform `XCTSkip`. In the future when swift-testing begins to be adopted the logic in TestFeature can be used to build TestTraits that disable swift-testing tests.
|
Swift-testing can't really be adopted until sourcekit-lsp drops support for Swift < 6.0, as swift-testing is only available in 6.0 and higher. Shelving this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static functions on the
SkipUnlessutility are used to skip XCTests unless some condition is met.Each of these methods effectively do two things:
XCTSkipTo facilitate the adoption of swift-testing, these feature conditions need to be able to be checked without involving XCTest methods.
Break out the feature detection in to
TestFeature, and have the methods onSkipUnlesscall these methods and then performXCTSkip.In the future when swift-testing begins to be adopted the logic in TestFeature can be used to build TestTraits that disable swift-testing tests.