Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove indexPrefixMappings from BuildSystem #1570

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Remove indexPrefixMappings from BuildSystem #1570

merged 1 commit into from
Aug 5, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 17, 2024

They weren’t used.

@ahoppen ahoppen requested a review from bnbarham July 17, 2024 22:20
@ahoppen
Copy link
Member Author

ahoppen commented Jul 17, 2024

@swift-ci Please test

bnbarham
bnbarham reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use them instead? They're needed if the index was built with prefix mappings, which would be nice to support. Probably need to add them as options to sourcekit-lsp as well (in cases where it's not possible to retrieve from the build system).

@ahoppen ahoppen marked this pull request as draft July 29, 2024 22:55
@ahoppen ahoppen force-pushed the remove-indexpathmappings branch from 43a75e5 to 0249741 Compare August 1, 2024 17:11
@ahoppen ahoppen mentioned this pull request Aug 1, 2024
Open
@ahoppen ahoppen marked this pull request as ready for review August 1, 2024 17:14
@ahoppen
Copy link
Member Author

ahoppen commented Aug 1, 2024

Since the current BuildSystem.indexPrefixMappings wasn’t doing anything, let’s remove it. I opened #1608 to properly add index prefix mapping support to build systems.

@ahoppen
Copy link
Member Author

ahoppen commented Aug 1, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Aug 1, 2024

@swift-ci Please test Windows

@ahoppen ahoppen requested a review from hamishknight August 1, 2024 22:17
@ahoppen ahoppen merged commit c31122b into swiftlang:main Aug 5, 2024
3 checks passed
@ahoppen ahoppen deleted the remove-indexpathmappings branch August 5, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham left review comments

@hamishknight hamishknight hamishknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahoppen @bnbarham @hamishknight