[BoundsSafety] Fix for opt-remarks #9771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of opt-remarks is non-deterministic because it checks the output while iterating over a DenseMap. To fix this issue, we can replace DenseMap with MapVector.
|
@rapidsna Can you please review it? |
rapidsna
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks @kyulee-com! LGTM. Looping @fhahn @juliannagele for visibility.
|
@rapidsna I don't have the permission to test and merge it. Could you please handle this for me? |
|
@swift-ci test |
|
@swift-ci please test windows platform |
|
@swift-ci please test llvm |
|
The LLVM one will fail because there's a lot more test broken, but we can check if the fixed tests are or not in the output. |
Yes, the baseline seems to be broken, but the output for the failed tests doesn't include opt-remarks. So, this PR appears to be valid. |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of opt-remarks is non-deterministic because it checks the output while iterating over a DenseMap. To fix this issue, we can replace DenseMap with MapVector.