Abhay/swift/bugfix outlining with stackrestore #9723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure code extraction for outlining to a function does not create a function with tail-call i.e. using stacksave of caller to restore stack. Code Extractor can include all other basic blocks without such stack restore blocks. symmetric scenario with stacksave with out-of-fn use
refined fix with only instructions in block
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Transforms][CodeExtraction] bug fix regions with stackrestore
Ensure code extraction for outlining to a function does not create a function with stacksave/ stackrestore referring to stack from outside the function.