Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Preserve import/export order in compat pass #5249

Merged
merged 8 commits into from
Jul 20, 2022
Merged

fix(es/compat): Preserve import/export order in compat pass #5249

merged 8 commits into from
Jul 20, 2022

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jul 19, 2022
@magic-akari magic-akari changed the title fix(es/compat): Preserve import/export order for export_namespace_from pass fix(es/compat): Preserve import/export order in compat pass Jul 19, 2022
@magic-akari magic-akari marked this pull request as ready for review July 19, 2022 06:36
kdy1
kdy1 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_compat
  • swc_ecma_transforms_proposal

@kdy1 kdy1 enabled auto-merge (squash) July 20, 2022 06:32
swc-bot
swc-bot reviewed Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 2010409 into swc-project:main Jul 20, 2022
@magic-akari magic-akari deleted the es/compat/export_namespace_from branch July 20, 2022 08:52
GiveMe-A-Name pushed a commit to GiveMe-A-Name/swc that referenced this pull request Jul 23, 2022
@magic-akari @GiveMe-A-Name
fix(es/compat): Preserve orders of imports and exports (swc-proje…
d997a6f 
…ct#5249)
@kdy1 kdy1 modified the milestones: Planned, v1.2.219 Jul 27, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.219
Development

Successfully merging this pull request may close these issues.
3 participants
@magic-akari @kdy1 @swc-bot