Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate expected output for svelte 4 and 5 #13093

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Dec 2, 2024

Re-adds the expected output of the svelte-package tests for svelte 4. Probably only useful if we have a test matrix / command for svelte 4 too but I'm not sure how to do that. Feel free to take over from here.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added the pkg:svelte-package Issues related to svelte-package label Dec 2, 2024
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 1fa49bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dominikg
Copy link
Member

dominikg commented Dec 2, 2024

❤️ this is great, we can set up a separate ci job to test svelte4 or introduce a matrix, but matrix gets a bit more complicated as we'd have to introduce a few "run if" s

We possibly also have to skip a few tests based on svelte version if they target specific behavior (eg if we start to introduce kit making use of svelte5 features if the user brings svelte5)

@benmccann
Copy link
Member

Perhaps it should be expected and expected ^4. That when when we drop Svelte 4 support we just have to delete expected ^4

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13093-svelte.vercel.app/

this is an automated message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:svelte-package Issues related to svelte-package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants