Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support encrypted values in config #3013

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: support encrypted values in config #3013

wants to merge 1 commit into from
+124 −4

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 3, 2025 •
edited
Loading

What kind of change does this PR introduce?

feature

What is the new behavior?

Follow dotenvx convention for encrypted secrets.

api_key = "encrypted:<base64_encoded>"

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 3, 2025 12:24
@coveralls
Copy link

coveralls commented Jan 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12597749124

Details

  • 19 of 31 (61.29%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 59.685%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/secret.go 19 31 61.29%
Files with Coverage Reduction New Missed Lines %
pkg/storage/buckets.go 2 83.33%
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12595878677: -0.04%
Covered Lines: 7685
Relevant Lines: 12876
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avallete avallete avallete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sweatybridge @coveralls @avallete