Markdown parsing bug search #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrianHicks published with 4.0.2 |
|
Thank you!
… On Oct 11, 2019, at 2:09 AM, Christoph Hermann ***@***.***> wrote:
@BrianHicks published with 4.0.2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way to fix the problem in #88. Turns out the file index was always
0for all Markdown suites. That meant that they would get overwritten! Whoops.That said, I'm not sure this is the best way to fix this. For example:
Test_0_{X}.elm—the 0 stays constant even though it now has a unique filename. Maybe we should discard the file index here since Markdown files can't have multiple functions?