Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix get null podCIDR and serviceCIDR #4476

Merged

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4464

Special notes for your reviewer:

Signed-off-by: ruochen <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 1.40%. Comparing base (7a0dd79) to head (9412447).
Report is 2 commits behind head on release-v0.8.

Files with missing lines Patch % Lines
pkg/coordinatormanager/coordinator_informer.go 0.00% 42 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.8   #4476       +/-   ##
================================================
- Coverage         80.86%   1.40%   -79.47%     
================================================
  Files                49      54        +5     
  Lines              5446    6332      +886     
================================================
- Hits               4404      89     -4315     
- Misses              880    6233     +5353     
+ Partials            162      10      -152     
Flag Coverage Δ
unittests 1.40% <0.00%> (-79.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/coordinatormanager/coordinator_informer.go 0.00% <0.00%> (ø)

... and 53 files with indirect coverage changes

@weizhoublue
Copy link
Collaborator

看着,只有 这个 0.8 分支 会出现 CI 的chart 错误

@cyclinder
Copy link
Collaborator Author

看着,只有 这个 0.8 分支 会出现 CI 的chart 错误

在哪里出现错误?

@weizhoublue weizhoublue merged commit d3fda3e into spidernet-io:release-v0.8 Dec 31, 2024
48 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants