Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller panic in cilium ipam is multi-pool #4433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyclinder
Copy link
Collaborator

@cyclinder cyclinder commented Dec 23, 2024

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4428

Special notes for your reviewer:

  1. 修复单 ipv4 时检查 cilium multi pool 的 ipv6 cidr
  2. 修改默认cilium 启动模式为 native, 便于 e2e 中更好测试 cilium ipam 的不同 mode
  3. 增加 e2e 测试

@cyclinder cyclinder added release/bug cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (7fd26d8) to head (22df46d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4433      +/-   ##
==========================================
- Coverage   79.26%   79.21%   -0.05%     
==========================================
  Files          54       54              
  Lines        6283     6283              
==========================================
- Hits         4980     4977       -3     
- Misses       1108     1110       +2     
- Partials      195      196       +1     
Flag Coverage Δ
unittests 79.21% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

lou-lan
lou-lan previously approved these changes Dec 24, 2024
@cyclinder cyclinder force-pushed the spidercoordinator/fix_cilium_cidr branch 15 times, most recently from 124a63a to d58f50e Compare December 27, 2024 11:23
@cyclinder cyclinder force-pushed the spidercoordinator/fix_cilium_cidr branch from d58f50e to 22df46d Compare December 27, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. release/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation failed in an environment with cilium cni as the main plugin
2 participants