fix: Missing GLIBC dynamic dependency makes ovs binary unavailable #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-dc
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
This was referenced Jul 23, 2024
|
CI tests passed, see https://github.com/ty-dc/spiderpool/actions/runs/10056954376/job/27797226992 |
weizhoublue
reviewed
Jul 23, 2024
images/spiderpool-plugins/Dockerfile
Outdated
| @@ -47,7 +47,7 @@ RUN git checkout ${RDMA_VERSION} && make TARGET_ARCH=${TARGETARCH} \ | |||
| TARGET_OS=${TARGETOS} build | |||
|
|
|||
| WORKDIR /src/ovs-cni | |||
| RUN mkdir -p build && GOOS=${TARGETOS} GOARCH=${TARGETARCH} go build -tags no_openssl -mod vendor -o build/ovs ./cmd/plugin | |||
| RUN mkdir -p build && GOOS=${TARGETOS} GOARCH=${TARGETARCH} CGO_ENABLED=0 go build -ldflags -v -ldflags="-s -w" -tags no_openssl -mod vendor -o build/ovs ./cmd/plugin | |||
|
|
|||
| WORKDIR /src/ib-sriov-cni | |||
| RUN git checkout ${IB_SRIOV_VERSION} && go mod vendor && mkdir -p build && GOOS=${TARGETOS} GOARCH=${TARGETARCH} CGO_ENABLED=0 go build -tags no_openssl -mod vendor -o build/ib-sriov ./cmd/ib-sriov-cni | |||
There was a problem hiding this comment.
guarrentee other binary for ldflags issue
Signed-off-by: tao.yang <[email protected]>
ty-dc
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
weizhoublue
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3741
Special notes for your reviewer: