edit changelog

spatie · Feb 15, 2018 · 99b2215 · 99b2215
1 parent 20174d0
commit 99b2215
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to `laravel-sluggable` will be documented in this file
 
+## 2.1.3 - 2018-02-15
+
+- fix for models with non incrementing primary keys
+
 ## 2.1.2 - 2018-02-08
 
 - Support Laravel 5.6

diff --git a/src/HasSlug.php b/src/HasSlug.php
@@ -149,8 +149,14 @@ protected function makeSlugUnique(string $slug): string
      */
     protected function otherRecordExistsWithSlug(string $slug): bool
     {
+        $key = $this->getKey();
+
+        if ($this->incrementing) {
+            $key = $key ?? '0';
+        }
+
         return (bool) static::where($this->slugOptions->slugField, $slug)
-            ->where($this->getKeyName(), '!=', $this->getKey() ?? '0')
+            ->where($this->getKeyName(), '!=', $key)
             ->withoutGlobalScopes()
             ->first();
     }