Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Game Networking #1532

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Add Game Networking #1532

merged 1 commit into from
Feb 26, 2019

Conversation

0xFA11
Copy link
Contributor

@0xFA11 0xFA11 commented Feb 23, 2019

https://github.com/MFatihMAR/Awesome-Game-Networking

Game networking is a subset of computer networking that covers data replication, state synchronization, snapshot interpolation, client prediction, lag compensation, bandwidth optimization and many more techniques involved in multiplayer online gameplay programming.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • I have read and understood the instructions for creating a list.
  • This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.
  • The entry in the Awesome list should:
    • Include a short description about the project/theme of the list. It should not describe the list itself.
      Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
    • Be added at the bottom of the appropriate category.
  • The list I'm submitting complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • It's the result of hard work and the best I could possibly produce.
  • Non-generated Markdown file in a GitHub repo.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

@0xFA11 0xFA11 mentioned this pull request Feb 23, 2019
readme.md Show resolved Hide resolved
@sindresorhus
Copy link
Owner

❯ awesome-lint https://github.com/MFatihMAR/Awesome-Game-Networking
✖ Linting

  README.md:75:3
  ✖    9:1  First heading should be name of awesome list                       remark-lint:awesome/toc
  ✖   75:3  Link to https://www.udemy.com/unrealengine-cpp/ is dead            remark-lint:no-dead-urls
  ✖   76:3  Link to https://www.udemy.com/unrealmultiplayer/ is dead           remark-lint:no-dead-urls
  ✖  114:3  Link to https://wiki.linuxfoundation.org/networking/netem is dead  remark-lint:no-dead-urls

  4 errors

https://github.com/sindresorhus/awesome-lint

@sindresorhus
Copy link
Owner

Instead of C# / Lidgren.Network, I would make it a sub-list:

  • C#
    • Lidgren.Network

@sindresorhus
Copy link
Owner

Otherwise, looks good :)

@0xFA11
Copy link
Contributor Author

0xFA11 commented Feb 26, 2019

First heading should be name of awesome list

Well, it has full-width SVG banner for the logo (and name) instead.

Link to https://www.udemy.com/unrealengine-cpp/ is dead
Link to https://www.udemy.com/unrealmultiplayer/ is dead
Link to https://wiki.linuxfoundation.org/networking/netem is dead

This one is interesting because they are not dead, I manually checked links and also double-checked README.md but still getting these errors. (I'm confused, they are alive!)

Instead of C# / Lidgren.Network, I would make it a sub-list

Sure, good idea!

@0xFA11
Copy link
Contributor Author

0xFA11 commented Feb 26, 2019

I updated all sections and they have cool subsections now.

Thanks for the feedback @sindresorhus :)

@sindresorhus
Copy link
Owner

This one is interesting because they are not dead, I manually checked links and also double-checked README.md but still getting these errors. (I'm confused, they are alive!)

transitive-bullshit/check-links#4

@sindresorhus
Copy link
Owner

Well, it has full-width SVG banner for the logo (and name) instead.

Right. Ignore that.

@sindresorhus sindresorhus merged commit a86a29f into sindresorhus:master Feb 26, 2019
@sindresorhus
Copy link
Owner

Looks good :)

@sindresorhus
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants