Add EOSIO #1370

DanailMinchev · 2018-08-04T14:55:50Z

https://github.com/DanailMinchev/awesome-eosio

EOSIO is the most powerful infrastructure for decentralized applications.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
I have read and understood the instructions for creating a list.
This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.
The entry in the Awesome list should:
- Include a short description about the project/theme of the list. It should not describe the list itself.
  Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
- Be added at the bottom of the appropriate category.
The list I'm submitting complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.
- Either fullwidth or placed at the top-right of the readme. (Example)
- The image should link to the project website or any relevant website.
- The image should be high-DPI. Set it to maximum half the width of the original image.
Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.
- Should be placed on the right side of the readme heading.
- Should link back to this list.
Has a Table of Contents section.
- Should be named Contents, not Table of Contents.
- Should be the first section in the list.
- Should only have one level of sub-lists, preferably none.
Has an appropriate license.
- That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
- WTFPL and Unlicense are not acceptable licenses.
- If you use a license badge, it should be SVG, not PNG.
Has contribution guidelines.
- The file should be named contributing.md. Casing is up to you.
Has consistent formatting and proper spelling/grammar.
- The link and description are separated by a dash.
  Example: - [AVA](…) - JavaScript test runner.
- The description starts with an uppercase character and ends with a period.
- Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
Doesn't include a Travis badge.
You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

styfle · 2018-08-06T01:53:29Z

readme.md

@@ -487,12 +487,15 @@
 - [Network Analysis](https://github.com/briatte/awesome-network-analysis#readme)
 - [PCAPTools](https://github.com/caesar0301/awesome-pcaptools#readme)

+


Remove this extra whitespace

I have added this line, because the sections ends with two lines and looks like we are missing one for Decentralized Systems.
For example all of the sections have two lines above their section names, please check:

Networking

Work

Business

etc

However, I have removed it - let me know if you want me to add it again and agree with the correction.

styfle · 2018-08-06T01:56:53Z

readme.md

 ## Decentralized Systems

 - [Bitcoin](https://github.com/igorbarinov/awesome-bitcoin#readme) - Bitcoin services and tools for software developers.
 - [Ripple](https://github.com/vhpoet/awesome-ripple#readme) - Open source distributed settlement network.
 - [Non-Financial Blockchain](https://github.com/machinomy/awesome-non-financial-blockchain#readme) - Non-financial blockchain applications.
 - [Mastodon](https://github.com/tleb/awesome-mastodon#readme) - Open source decentralized microblogging network.
+- [EOS](https://github.com/DanailMinchev/awesome-eos#readme) - EOS.IO is a decentralized operating system supporting industrial-scale applications.


This seems a little inconsistent. The link name is [EOS] but then you call it EOS.IO immediately after. I don't think you need both. Change the description to

A decentralized operating system supporting industrial-scale applications.

Also, the website refers to itself as EOSIO so maybe you should rename the link and your repo to awesome-eosio.

Also change this PR title to Add EOSIO and no need to indicate which section

A lot of sections have parenthesis such as (developers) but I don't think is this is necessary; it adds clutter.

Many of the descriptions are missing or duplicates such as "Block explorer". Can these be more descriptive so it's clear how each entry in the list is different?

The logo must be either fullwidth or placed at the top-right of the readme. It should also link to the EOSIO website.

DanailMinchev · 2018-08-12T22:13:12Z

Thank you for the review @styfle ! :)
I addressed your comments, could you review again?
Thanks

styfle · 2018-08-13T16:51:30Z

I think you can remove the "More information" lines. They are adding an unnecessary indentation level.

styfle · 2018-08-13T16:52:11Z

Also, I recently found out that each description is supposed to end with a period. https://twitter.com/styfle/status/1025843172839055362

styfle

I think you can remove the "More information" lines. They are adding an unnecessary indentation level.

Also each description needs to end with a period.

DanailMinchev · 2018-08-13T21:55:06Z

@styfle all done, thanks

styfle

LGTM 👍

DanailMinchev · 2018-08-14T22:59:49Z

Hi @sindresorhus , great project !

Updates about my PR: it was reviewed and approved ( thanks @styfle )

As per your suggestions in Project status #1363, I have reviewed and commented on several PR's to help the project.
I've ran this through awesome-lint which pointed out some issues and I fixed them.
awesome-lint was very useful and I put a comment with the full report in my PR reviews.

Some of the reviews/comments:

Reviews

Second review

Add DigitalOcean #1053 (review)

Comments

or full list - https://github.com/sindresorhus/awesome/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3ADanailMinchev

@sindresorhus could you let me know if everything is ok or should I address something else to move forward?

Thank you!

DanailMinchev · 2019-01-26T14:19:27Z

@sindresorhus could you let me know if something else needs to be done?

sindresorhus · 2019-02-26T08:53:10Z

❯ awesome-lint https://github.com/DanailMinchev/awesome-eosio
✖ Linting

  readme.md:192:3
  ✖  154:3  Link to https://www.buyeosram.io/ is dead                                                remark-lint:no-dead-urls
  ✖  192:3  Link to https://www.udemy.com/learning-blockchain-development-with-eos-and-cpp/ is dead  remark-lint:no-dead-urls
  ✖  193:3  Link to https://www.udemy.com/starting-with-eos/ is dead                                 remark-lint:no-dead-urls
  ✖  334:3  Link to https://eosprojects.org/ is dead                                                 remark-lint:no-dead-urls

  4 errors

https://github.com/sindresorhus/awesome-lint

sindresorhus · 2019-02-26T08:53:21Z

Can you fix the merge conflict?

sindresorhus · 2019-02-26T08:54:15Z

Includes a project logo/illustration whenever possible.
The image should be high-DPI. Set it to maximum half the width of the original image.

sindresorhus · 2019-02-26T08:54:56Z

In the Official section, there's no need to prefix everything with EOSIO. That already implied and obvious.

sindresorhus · 2019-02-26T08:55:54Z

Items in the Blogs and YouTube Channels section should have a description.

sindresorhus · 2019-02-26T08:56:29Z

Looks weird to have a linebreak between these paragraphs:

EOSIO is the most powerful infrastructure for decentralized applications and open source smart contract platform.
EOSIO software enables businesses to rapidly build and deploy high-performance and high-security blockchain-based applications.

DanailMinchev · 2019-02-26T21:25:53Z

Thank you for the review @sindresorhus !

I have addressed your comments, could you re-review please?

Some information:

about the awesome-lint report:

❯ awesome-lint https://github.com/DanailMinchev/awesome-eosio
✖ Linting

  readme.md:192:3
  ✖  154:3  Link to https://www.buyeosram.io/ is dead                                                remark-lint:no-dead-urls
  ✖  192:3  Link to https://www.udemy.com/learning-blockchain-development-with-eos-and-cpp/ is dead  remark-lint:no-dead-urls
  ✖  193:3  Link to https://www.udemy.com/starting-with-eos/ is dead                                 remark-lint:no-dead-urls
  ✖  334:3  Link to https://eosprojects.org/ is dead                                                 remark-lint:no-dead-urls

  4 errors

Looks like only https://www.buyeosram.io/ is invalid.

Following links are valid:
https://www.udemy.com/learning-blockchain-development-with-eos-and-cpp/
https://www.udemy.com/starting-with-eos/
https://eosprojects.org/

I have removed them anyway, but would like to add them if you think it is awesome-lint bug, please let me know.

I have uploaded a new logo as well and addressed all other comments.

Cheers

sindresorhus · 2019-03-03T14:03:41Z

I have removed them anyway, but would like to add them if you think it is awesome-lint bug, please let me know.

It's probably this issue: transitive-bullshit/check-links#4 Feel free to add them back.

sindresorhus · 2019-03-03T14:05:21Z

Tweet: https://twitter.com/awesome__re/status/1102208276840640517

styfle mentioned this pull request Aug 6, 2018

Add Online IDEs #1124

Closed

37 tasks

styfle suggested changes Aug 6, 2018

View reviewed changes

DanailMinchev changed the title ~~Add "EOS" to "Decentralized Systems" section~~ Add EOSIO Aug 12, 2018

styfle suggested changes Aug 13, 2018

View reviewed changes

styfle approved these changes Aug 14, 2018

View reviewed changes

Add "EOSIO" to "Decentralized Systems" section

e079836

Update readme.md

baa04f9

sindresorhus mentioned this pull request Mar 3, 2019

Investigate false negatives transitive-bullshit/check-links#4

Open

sindresorhus merged commit bf97a1a into sindresorhus:master Mar 3, 2019

DanailMinchev deleted the patch-1 branch March 3, 2019 14:06

0exbot mentioned this pull request Oct 27, 2022

Add Online IDEs 0ex/more-awesome#195

Merged

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EOSIO #1370

Add EOSIO #1370

DanailMinchev commented Aug 4, 2018 •

edited

Loading

styfle Aug 6, 2018

DanailMinchev Aug 12, 2018

styfle Aug 6, 2018

styfle Aug 6, 2018

styfle Aug 6, 2018

styfle Aug 6, 2018

styfle Aug 6, 2018

DanailMinchev commented Aug 12, 2018 •

edited

Loading

styfle commented Aug 13, 2018

styfle commented Aug 13, 2018

styfle left a comment

DanailMinchev commented Aug 13, 2018

styfle left a comment

DanailMinchev commented Aug 14, 2018 •

edited

Loading

DanailMinchev commented Jan 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019 •

edited

Loading

DanailMinchev commented Feb 26, 2019

sindresorhus commented Mar 3, 2019

sindresorhus commented Mar 3, 2019

		@@ -487,12 +487,15 @@
		- [Network Analysis](https://github.com/briatte/awesome-network-analysis#readme)
		- [PCAPTools](https://github.com/caesar0301/awesome-pcaptools#readme)

Add EOSIO #1370

Add EOSIO #1370

Conversation

DanailMinchev commented Aug 4, 2018 • edited Loading

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Requirements for your pull request

Requirements for your Awesome list

styfle Aug 6, 2018

Choose a reason for hiding this comment

DanailMinchev Aug 12, 2018

Choose a reason for hiding this comment

styfle Aug 6, 2018

Choose a reason for hiding this comment

styfle Aug 6, 2018

Choose a reason for hiding this comment

styfle Aug 6, 2018

Choose a reason for hiding this comment

styfle Aug 6, 2018

Choose a reason for hiding this comment

styfle Aug 6, 2018

Choose a reason for hiding this comment

DanailMinchev commented Aug 12, 2018 • edited Loading

styfle commented Aug 13, 2018

styfle commented Aug 13, 2018

styfle left a comment

Choose a reason for hiding this comment

DanailMinchev commented Aug 13, 2018

styfle left a comment

Choose a reason for hiding this comment

DanailMinchev commented Aug 14, 2018 • edited Loading

DanailMinchev commented Jan 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019

sindresorhus commented Feb 26, 2019 • edited Loading

DanailMinchev commented Feb 26, 2019

sindresorhus commented Mar 3, 2019

sindresorhus commented Mar 3, 2019

DanailMinchev commented Aug 4, 2018 •

edited

Loading

DanailMinchev commented Aug 12, 2018 •

edited

Loading

DanailMinchev commented Aug 14, 2018 •

edited

Loading

sindresorhus commented Feb 26, 2019 •

edited

Loading