Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Alternatives #1330

Closed
wants to merge 2 commits into from

Conversation

anatolinicolae
Copy link

https://github.com/ianchanning/awesome-github-alternatives

A list of alternatives to Github after Microsoft acquisition 🤷‍♂️ .

@legodude17
Copy link

The list must be around for 30 days before it can be added.

@sindresorhus
Copy link
Owner

Hey, sorry for the lack of response, please see #1363.

Copy link
Contributor

@transitive-bullshit transitive-bullshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, but there are multiple issues with the format guidelines.

Please double-check all of them before submitting.

Here are a few that don't currently pass (there may bee others):

  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
  • Has a Table of Contents section.
  • Has contribution guidelines.

There are likely more issues; please update and we'll check it out again.

Thanks!

@transitive-bullshit transitive-bullshit mentioned this pull request Jul 29, 2018
19 tasks
@sindresorhus
Copy link
Owner

Ping @anatolinicolae

@anatolinicolae
Copy link
Author

/cc @ianchanning 😬

@ianchanning
Copy link

ianchanning commented Sep 30, 2018

Thanks @anatolinicolae. I've fixed those issues from @transitive-bullshit 's comment, I had tried to meet most of the guidelines, but at the time there was the hard and fast rule of 30 days.

I think I meet all the criteria except for these two arguable points:

  • It's the result of hard work and the best I could possibly produce.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Not a duplicate.

It's not a massive list, so there's only so much work required. I also haven't gone through the work of installing and trying all the systems. I did get all sources that came from what I thought were reasonable recommendations (mostly Hacker News) and then matched them up with the website's information. I've made the effort to make sure that everything is neatly categorised so that if you want a specific technology / license then it's easy to find.

As for being a duplicate, as raised in the issues, the is a general awesome-git list which includes a lot of what's in mine. However the awesome git list is failing on quite a few of the guidelines and I don't know if they're going to fix them.

@ianchanning
Copy link

Also I obviously need to review two other awesome lists which I haven't done yet.

@ianchanning
Copy link

I have now been through at least two awesome lists done a basic review and left comments, but I'm not sure how you get added as a reviewer.

@sindresorhus
Copy link
Owner

❯ awesome-lint https://github.com/ianchanning/awesome-github-alternatives
✖ Linting

  README.md:22:1
  ✖  22:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  23:11  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  24:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  25:11  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  26:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  27:11  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  28:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  29:36  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  30:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  31:18  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  32:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  33:37  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  34:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  34:42  List item link and description must be separated with a dash  remark-lint:awesome/list-item
  ✖  36:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  36:44  Text "github" should be written as "GitHub"                   remark-lint:awesome/spell-check
  ✖  37:17  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  38:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  39:39  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  40:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  41:17  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  42:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  43:16  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  44:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  45:32  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  46:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  47:15  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  48:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  48:3   Link to https://www.tuleap.org is dead                        remark-lint:no-dead-urls
  ✖  49:22  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  50:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  51:11  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  52:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  53:11  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  54:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  55:18  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  56:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  57:18  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  63:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  63:38  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  64:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  64:52  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  65:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  66:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  66:3   Link to https://www.tuleap.org is dead                        remark-lint:no-dead-urls
  ✖  66:35  List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  67:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  68:5   List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  69:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  70:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  71:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  72:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  73:5   List item description must end with proper punctuation        remark-lint:awesome/list-item
  ✖  74:1   Marker style should be *                                      remark-lint:unordered-list-marker-style
  ✖  75:5   List item description must end with proper punctuation        remark-lint:awesome/list-item

  55 errors

https://github.com/sindresorhus/awesome-lint

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@sindresorhus
Copy link
Owner

It's not clear how the header image is related to GitHub?

@sindresorhus
Copy link
Owner

Lie back and read the Ts & Cs to see how they harvest your data.

Not clear what Ts and Cs is.

@sindresorhus
Copy link
Owner

GitLab - See above

Don't force the user to interrupt their flow and go look for the other entry. Duplicating the description is totally fine.

@ianchanning
Copy link

@sindresorhus Thank you for your comments, I can fix all the other issues, but https://www.tuleap.org is the correct working link, so I don't know how to get past the linter if it thinks that that is broken.

channi16@ICT0115123:~/$ wget https://www.tuleap.org
--2019-02-26 10:10:47--  https://www.tuleap.org/
Resolving www.tuleap.org (www.tuleap.org)... 163.172.41.21
Connecting to www.tuleap.org (www.tuleap.org)|163.172.41.21|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 14790 (14K) [text/html]
Saving to: ‘index.html’

index.html                 100%[=====================================>]  14.44K  --.-KB/s    in 0s      

2019-02-26 10:10:47 (85.2 MB/s) - ‘index.html’ saved [14790/14790]

@anatolinicolae
Copy link
Author

Running the linter locally would mark that as a working link since you're correctly resolving it 🤔

@ianchanning
Copy link

I haven't tried running the linter locally yet - but if it works locally that won't stop the problem that the server is having when it runs it

@ianchanning
Copy link

I'm just going to link to their Github repo, they bury links to their source code quite deeply

@ianchanning
Copy link

@sindresorhus I've run the linter locally and fixed all the linting issues. I've tried to improve the list by putting a section for each language rather than tags at the end and used badges for the licences to make them clearer.

I'm not sure what to do about the icon - it's just a hand waving bye bye. I couldn't think of a better logo. I can just remove it - I don't know the copyright issues around using the GitHub logo

@sindresorhus
Copy link
Owner

but tuleap.org is the correct working link, so I don't know how to get past the linter if it thinks that that is broken.

transitive-bullshit/check-links#4

@sindresorhus
Copy link
Owner

I couldn't think of a better logo. I can just remove it - I don't know the copyright issues around using the GitHub logo

The rules for using the GitHub logo is strict, but you could use an octocat instead: https://octodex.github.com/ (Just make sure you give proper credit) Combine that with the bye bye emoji and it could look good.

@ianchanning
Copy link

Is it ok if I just remove the logo? At the moment I can't see a good way of combining those two and I'm not good enough of a designer to make something that does look decent.

@sindresorhus
Copy link
Owner

Yes

@ianchanning
Copy link

Ok, removed

@ianchanning
Copy link

@sindresorhus Is there anything more required for this PR?

@sindresorhus
Copy link
Owner

The diff in this PR is not correct. It includes a lot of unrelated changes: https://github.com/sindresorhus/awesome/pull/1330/files

@sindresorhus
Copy link
Owner

The entry in the Awesome list should:
Include a short description about the project/theme of the list. It should not describe the list itself.

@sindresorhus sindresorhus changed the title Add Github Alternatives Add GitHub Alternatives May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants