-
-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Alternatives #1330
Add GitHub Alternatives #1330
Conversation
The list must be around for 30 days before it can be added. |
Hey, sorry for the lack of response, please see #1363. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission, but there are multiple issues with the format guidelines.
Please double-check all of them before submitting.
Here are a few that don't currently pass (there may bee others):
- Includes the Awesome badge.
- Should be placed on the right side of the readme heading.
- Has a Table of Contents section.
- Has contribution guidelines.
There are likely more issues; please update and we'll check it out again.
Thanks!
Ping @anatolinicolae |
/cc @ianchanning 😬 |
Thanks @anatolinicolae. I've fixed those issues from @transitive-bullshit 's comment, I had tried to meet most of the guidelines, but at the time there was the hard and fast rule of 30 days. I think I meet all the criteria except for these two arguable points:
It's not a massive list, so there's only so much work required. I also haven't gone through the work of installing and trying all the systems. I did get all sources that came from what I thought were reasonable recommendations (mostly Hacker News) and then matched them up with the website's information. I've made the effort to make sure that everything is neatly categorised so that if you want a specific technology / license then it's easy to find. As for being a duplicate, as raised in the issues, the is a general awesome-git list which includes a lot of what's in mine. However the awesome git list is failing on quite a few of the guidelines and I don't know if they're going to fix them. |
Also I obviously need to review two other awesome lists which I haven't done yet. |
I have now been through at least two awesome lists done a basic review and left comments, but I'm not sure how you get added as a reviewer. |
|
Can you fix the merge conflict? |
It's not clear how the header image is related to GitHub? |
Not clear what |
Don't force the user to interrupt their flow and go look for the other entry. Duplicating the description is totally fine. |
@sindresorhus Thank you for your comments, I can fix all the other issues, but https://www.tuleap.org is the correct working link, so I don't know how to get past the linter if it thinks that that is broken. channi16@ICT0115123:~/$ wget https://www.tuleap.org
--2019-02-26 10:10:47-- https://www.tuleap.org/
Resolving www.tuleap.org (www.tuleap.org)... 163.172.41.21
Connecting to www.tuleap.org (www.tuleap.org)|163.172.41.21|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 14790 (14K) [text/html]
Saving to: ‘index.html’
index.html 100%[=====================================>] 14.44K --.-KB/s in 0s
2019-02-26 10:10:47 (85.2 MB/s) - ‘index.html’ saved [14790/14790] |
Running the linter locally would mark that as a working link since you're correctly resolving it 🤔 |
I haven't tried running the linter locally yet - but if it works locally that won't stop the problem that the server is having when it runs it |
I'm just going to link to their Github repo, they bury links to their source code quite deeply |
@sindresorhus I've run the linter locally and fixed all the linting issues. I've tried to improve the list by putting a section for each language rather than tags at the end and used badges for the licences to make them clearer. I'm not sure what to do about the icon - it's just a hand waving bye bye. I couldn't think of a better logo. I can just remove it - I don't know the copyright issues around using the GitHub logo |
|
The rules for using the GitHub logo is strict, but you could use an octocat instead: https://octodex.github.com/ (Just make sure you give proper credit) Combine that with the bye bye emoji and it could look good. |
Is it ok if I just remove the logo? At the moment I can't see a good way of combining those two and I'm not good enough of a designer to make something that does look decent. |
Yes |
Ok, removed |
@sindresorhus Is there anything more required for this PR? |
The diff in this PR is not correct. It includes a lot of unrelated changes: https://github.com/sindresorhus/awesome/pull/1330/files |
|
https://github.com/ianchanning/awesome-github-alternatives
A list of alternatives to Github after Microsoft acquisition 🤷♂️ .