Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Mhz to current, min and max. #1517

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexwbaule
Copy link

Implement of #1516

Please, is my first PR here, and i only have Linux to test it.

@shirou shirou added the v4 label Aug 29, 2023
@shirou
Copy link
Owner

shirou commented Aug 29, 2023

Thank you for your contribution. However, unfortunately, this PR breaks current compatibility. So we cannot accept while in current major version, v3. I have added v4 label, but v4 release date is not discussed yet.

@alexwbaule
Copy link
Author

Hi @shirou , can we merge this ?

@shirou
Copy link
Owner

shirou commented Oct 14, 2023

As I commented, this PR breaks current compatibility. So we cannot merge until v4 is released.

@kkartaltepe
Copy link

kkartaltepe commented Nov 19, 2024

It seems the current version is v4 now can this be considered again? I was also interested in this data.

--- Edit

And if it does get picked back up a fallback to scaling_cur_freq should be added to support amd-pstate's governor which only reports frequency from there https://docs.kernel.org/admin-guide/pm/amd-pstate.html#key-governors-support (I don't know which is more correct on other platforms/configurations but amd-pstate doesnt report cpuinfo_cur_freq at all).

@alexwbaule
Copy link
Author

@shirou , need something to merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants