Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw an error when try to view a directory #234

Merged
merged 2 commits into from
Dec 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# unreleased

## Bugfixes

- Throw an error when try to view a directory, see #234 (@Integral-Tech)

# v0.15.0

## Features
Expand Down
9 changes: 8 additions & 1 deletion src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,14 @@ fn run() -> Result<()> {
let stdin = io::stdin();

let mut reader = match opt.file {
Some(filename) => Input::File(File::open(filename)?),
Some(filename) => {
let file = File::open(&filename)?;
if file.metadata()?.is_dir() {
return Err(anyhow!("{} is a directory.", filename.display()));
}
Integral-Tech marked this conversation as resolved.
Show resolved Hide resolved

Input::File(file)
}
None => Input::Stdin(stdin.lock()),
};

Expand Down
Loading