Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aggregate issue] Missing opcodes #496

Open
22 tasks done
rafael-57 opened this issue Aug 20, 2024 · 71 comments · Fixed by #1590
Open
22 tasks done

[Aggregate issue] Missing opcodes #496

rafael-57 opened this issue Aug 20, 2024 · 71 comments · Fixed by #1590

Comments

@rafael-57
Copy link
Contributor

rafael-57 commented Aug 20, 2024 •
edited
Loading

Post your missing opcode errors here for devs to keep track of and implement.

Please check the currently implemented list first. Duplicates will be deleted.

Format

-- {Game Serial} {Game Name}
{Some log lines with "Unknown opcode"}
{upload full logfile}

Currently implemented

Game compatibility status

https://github.com/shadps4-emu/shadps4-game-compatibility/issues
@LeDragoX

This comment was marked as resolved.

Sign in to view
@gandalfthewhite19890404

This comment was marked as resolved.

Sign in to view
@AboMedoz

This comment was marked as resolved.

Sign in to view
@AboMedoz

This comment was marked as resolved.

Sign in to view
@pillo-jpg

This comment was marked as resolved.

Sign in to view
@gandalfthewhite19890404
Copy link

CUSA01998 - The Deadly Tower of Monsters
[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:449: Unknown opcode IMAGE_STORE_MIP (1411, category = VectorMemory)

@polybiusproxy

This comment was marked as resolved.

Sign in to view
@lzardy lzardy mentioned this issue Aug 24, 2024
Merged
@bigol83
Copy link
Contributor

bigol83 commented Aug 24, 2024

CUSA 03173 -Bloodborne Game of the Year Edition Patch 1.09

Unimplemented PM4 opcode

[Debug] <Critical> liverpool.cpp:ProcessGraphics:459: Unreachable code!
Unknown PM4 type 3 opcode 0x11 with count 3

shad_log.txt

@lzardy lzardy mentioned this issue Aug 25, 2024
Closed
@desmonHak
Copy link

desmonHak commented Aug 25, 2024 •
edited
Loading

Bloodborne Game of the Year Edition Patch 1.09

CUSA 03173 and CUSA00900

Unknown PM4 type 3 opcode 0x11 with count 3.

shad_log.txt

This second log happened to me trying to run the same game but with version 1.0. The .txt log is about 100MB in size, that's why I compressed it.

shad_log2.zip

@bigol83

This comment was marked as resolved.

Sign in to view
@StevenMiller123

This comment was marked as resolved.

Sign in to view
@StevenMiller123
Copy link
Contributor

StevenMiller123 commented Aug 26, 2024 •
edited
Loading

Note: The game regressed in a recent build and no longer reaches this opcode.

FINAL FANTASY XV CUSA01633:

[Debug] <Critical> liverpool.cpp:ProcessCompute:561: Unreachable code!
Unknown PM4 type 3 opcode 0x78 with count 2

shad_log.txt

@StevenMiller123

This comment was marked as resolved.

Sign in to view
@LeDragoX

This comment was marked as resolved.

Sign in to view
@bigol83 bigol83 mentioned this issue Aug 27, 2024
Merged
@psucien psucien mentioned this issue Aug 28, 2024
Merged
@spacelilly
Copy link

CUSA00900 - Bloodborne
[Debug] liverpool.cpp:ProcessGraphics:495: Unreachable code!
Unknown PM4 type 3 opcode 0x24 with count 4
shad_log.txt

@psucien psucien mentioned this issue Aug 30, 2024
Merged
This was referenced Sep 1, 2024
Merged
Merged
@Emulator-Team-2

This comment was marked as resolved.

Sign in to view
StevenMiller123 added a commit to StevenMiller123/shadPS4 that referenced this issue Sep 5, 2024
@StevenMiller123
Implement some missing shader opcodes
2180824 
Implements TBUFFER_STORE_FORMAT_XYZW, IMAGE_SAMPLE_CD, and IMAGE_GATHER4_C_LZ.

These are seen in shadps4-emu#496.
@StevenMiller123 StevenMiller123 mentioned this issue Sep 5, 2024
Merged
raphaelthegreat pushed a commit that referenced this issue Sep 6, 2024
@StevenMiller123
shader_recompiler: Add more opcodes (#802)
09ce12a 
* Implement some missing shader opcodes

Implements TBUFFER_STORE_FORMAT_XYZW, IMAGE_SAMPLE_CD, and IMAGE_GATHER4_C_LZ.

These are seen in #496.

* Implement IMAGE_STORE_MIP

Not sure if this is the right way to do this, let me know if this needs changing.

* Revert "Implement IMAGE_STORE_MIP"

This reverts commit cff78b5.
@gandalfthewhite19890404

This comment was marked as resolved.

Sign in to view
@amiddendorp22 amiddendorp22 mentioned this issue Sep 7, 2024
Merged
@Emulator-Team-2

This comment was marked as resolved.

Sign in to view
@Emulator-Team-2

This comment was marked as resolved.

Sign in to view
@Hermiten
Copy link
Collaborator

Hermiten commented Nov 22, 2024 •
edited
Loading

CUSA03219 - Star Ocean: Integrity and Faithlessness end of log

[Tty] kernel.cpp:ps4__write:163: strcpy_s: bad argument [Kernel.Event] event_flag.cpp:sceKernelCancelEventFlag:236: (STUBBED) called

This is not the right place, there is no opcodes here

@rafael-57 Hey can you please update your first post ? Some new opcodes :)
Thanks you

@f8ith f8ith mentioned this issue Nov 24, 2024
Merged
@psucien psucien reopened this Nov 24, 2024
@f8ith f8ith mentioned this issue Nov 25, 2024
Merged
@kvicken
Copy link

kvicken commented Nov 27, 2024

CUSA01623 - God of War® III Remastered

[Debug] liverpool.cpp:ProcessGraphics:640: Unreachable code!
Unknown PM4 type 3 opcode 0x20 with count 2

shad_log.txt

@Foul-Tarnished
Copy link

Foul-Tarnished commented Nov 29, 2024 •
edited
Loading

CUSA04943 - Gravity Rush™️ 2
Unknown opcode IMAGE_STORE_MIP (1411, category = VectorMemory)

[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:452: Unknown opcode IMAGE_STORE_MIP (1411, category = VectorMemory)
[Debug] <Critical> structured_control_flow.cpp:operator():835: Assertion Failed!
Shader translation has failed

shad_log.txt
(technically a duplicate, but the other comment is missing a log file..)

@alphavector
Copy link
Contributor

CUSA00501 - SingStar Ultimate Party

[Debug] <Critical> liverpool.cpp:ProcessGraphics:621: Unreachable code!
Unknown PM4 type 3 opcode 0x20 with count 2

shadps4-emu/shadps4-game-compatibility#1242

@alphavector
Copy link
Contributor

CUSA15326 - YAKUZA 4

[Debug] <Critical> liverpool.cpp:ProcessCompute:650: Unreachable code!
Unknown PM4 type 3 opcode 0x78 with count 2

shadps4-emu/shadps4-game-compatibility#895

@alphavector
Copy link
Contributor

CUSA00938 - Homefront®: The Revolution

[Debug] <Critical> liverpool.cpp:ProcessCompute:650: Unreachable code!
Unknown PM4 type 3 opcode 0x78 with count 2

shadps4-emu/shadps4-game-compatibility#776

@alphavector
Copy link
Contributor

CUSA00107 - Tomb Raider: Definitive Edition

[Debug] liverpool.cpp:ProcessGraphics:550: Unreachable code!
Unknown PM4 type 3 opcode 0x39 with count 2

shadps4-emu/shadps4-game-compatibility#693

@alphavector

This comment was marked as resolved.

Sign in to view
@kalaposfos13

This comment was marked as resolved.

Sign in to view
@StevenMiller123 StevenMiller123 mentioned this issue Dec 2, 2024
Closed
@Graubek
Copy link

Graubek commented Dec 5, 2024

CUSA00002 - KILLZONE™ SHADOW FALL

[Debug] <Critical> liverpool.cpp:ProcessGraphics:640: Unreachable code!
Unknown PM4 type 3 opcode 0x20 with count 2

shad_log.txt

@bigol83
Copy link
Contributor

bigol83 commented Dec 7, 2024 •
edited
Loading

CUSA15325 - YAKUZA 3

[Debug] <Critical> liverpool.cpp:ProcessCompute:786: Unreachable code!
Unknown PM4 type 3 opcode 0x78 with count 2

shad_log.txt

@kvicken
Copy link

kvicken commented Dec 8, 2024

CUSA00004 inFAMOUS™ Second Son

[Debug] <Critical> liverpool.cpp:ProcessCompute:677: Unreachable code!
Invalid PM4 type 2

shad_log.txt

@AboMedoz
Copy link
Contributor

AboMedoz commented Dec 9, 2024

CUSA00004 inFAMOUS™ Second Son

[Debug] <Critical> liverpool.cpp:ProcessCompute:677: Unreachable code!
Invalid PM4 type 2

shad_log.txt

this is caused cuz you have 1.00 update your game to 1.07

@kvicken
Copy link

kvicken commented Dec 10, 2024

this is caused cuz you have 1.00 update your game to 1.07

I updated the game to 1.07 and it progress a little further. Now when the game crashes the emulator shows a different error:

[Debug] <Critical> liverpool_to_vk.h:PromoteFormatToDepth:105: Unreachable code!

shad_log.txt

@smiRaphi
Copy link

Not entirely sure if this should go here but Yo-Kai Watch 4++ [CUSA17589] crashes with this:

[Debug] <Critical> decode.cpp:operator():264: Assertion Failed!
Instruction format table incomplete for opcode  (13, encoding = )

shad_log.txt

@StevenMiller123
Copy link
Contributor

With a dmem sizes hack, Spider-Man Miles Morales hits

[Debug] <Critical> liverpool.cpp:ProcessGraphics:653: Unreachable code!
Unknown PM4 type 3 opcode 0x8e with count 3

If that error is skipped, the game hits

[Debug] <Critical> decode.cpp:operator():264: Assertion Failed!
Instruction format table incomplete for opcode S_MEMTIME (1022, encoding = )

And finally, if that error is worked around, the game hits all these missing opcodes

[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:491: Unknown opcode S_LSHL_B64 (31, category = ScalarALU)
[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:491: Unknown opcode V_CMP_EQ_U64 (391, category = VectorALU)
[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:491: Unknown opcode S_MEMTIME (1022, category = ScalarMemory)
[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:491: Unknown opcode V_CMP_GT_U64 (393, category = VectorALU)
[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:491: Unknown opcode V_CMP_LT_U64 (390, category = VectorALU)

@DeviousConundrum

This comment was marked as off-topic.

Sign in to view
@Graubek
Copy link

Graubek commented Dec 15, 2024

CUSA00006 - KNACK

[Debug] <Critical> liverpool.cpp:ProcessGraphics:700: Unreachable code!
Unknown PM4 type 3 opcode 0xff with count 16384

shad_log.txt

@Daniel-MM-Baptista

This comment was marked as off-topic.

Sign in to view
@StevenMiller123
Copy link
Contributor

@Daniel-MM-Baptista @DeviousConundrum PM4 Type 0 errors do not belong here, as they are a completely different problem from the PM4 type 3 opcode errors we report.

@DeviousConundrum
Copy link

@Daniel-MM-Baptista @DeviousConundrum PM4 Type 0 errors do not belong here, as they are a completely different problem from the PM4 type 3 opcode errors we report.

I'm going to be honest. I have no idea what I'm doing. I've been using a branch now, and I still get crashes. But the log doesn't show what makes it crash. So I made my peace with it. I may give it a try on Linux to see if I still crash due to PM4 error. Thank you for inadvertently giving me a push in the right direction ,

@alphavector
Copy link
Contributor

CUSA06559 - Prey

[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:446: Unknown opcode IMAGE_STORE_MIP (1411, category = VectorMemory)

shadps4-emu/shadps4-game-compatibility#1150

@Gabe205
Copy link

Gabe205 commented Dec 28, 2024

CUSA01778 - Dead or Alive 5 Last Round

[Render.Vulkan] vk_pipeline_cache.cpp:CompileModule:482: Compiling fs shader 0xc74ae8fd280e2ed4
[Render.Recompiler] translate.cpp:LogMissingOpcode:516: Unknown opcode S_ASHR_I64 (35, category = ScalarALU)
[Debug] structured_control_flow.cpp:operator():835: Assertion Failed!
Shader translation has failed

shad_log.txt

@blackreaper19
Copy link

blackreaper19 commented Dec 29, 2024 •
edited
Loading

CUSA08278 - Gintama Rumble

[Debug] liverpool_to_vk.cpp:MipFilter:310: Unreachable code!

shad_log.txt

@Hermiten
Copy link
Collaborator

@Gabe205 Only the second line is enough, thanks
@blackreaper19 This is not a opcode, you can remove your message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement DS_OR_B32 f8ith/shadPS4