Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update Dialog import to resolve interaction issue #6181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RahimGuerfi
Copy link
Contributor

@RahimGuerfi RahimGuerfi commented Dec 26, 2024


PR Title:

fix(app): update Dialog import to resolve interaction issue


Description:

This PR fixes a bug in the preset-actions.tsx file located at app/(app)/examples/playground/components/. The issue was caused by importing the Dialog component from @radix-ui/react-dialog instead of the correct path, @/registry/new-york/ui/dialog.

This incorrect import caused the dialog to malfunction, resulting in the page becoming non-interactable after closing the dialog.


Changes Made:

  • Updated the import statement for the Dialog component in preset-actions.tsx to use the correct path:
    import { Dialog } from "@/registry/new-york/ui/dialog";
  • Verified the fix to ensure the dialog behaves as expected and no longer causes page interaction issues.

Steps to Test:

  1. Navigate to the playground example in the app:
    app/(app)/examples/playground/components/preset-actions.tsx.
  2. Open the dialog and close it.
  3. Confirm that the page remains interactable and no issues arise.

Linked Issues (if any):

  • None reported, discovered during development/testing.

Checklist:

  • Code changes are tested and verified.
  • No new dependencies added.

Copy link

vercel bot commented Dec 26, 2024

@RahimGuerfi is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant