Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify Iterator::next for PercentEncode #1012

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hkBst
Copy link
Contributor

@hkBst hkBst commented Dec 23, 2024

This reduces duplication including of an unsafe block...

This reduces duplication including of an unsafe block...

Signed-off-by: Marijn Schouten <[email protected]>
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@84cf467). Learn more about missing BASE report.

Files with missing lines Patch % Lines
percent_encoding/src/lib.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage        ?   80.35%           
=======================================
  Files           ?       24           
  Lines           ?     4225           
  Branches        ?        0           
=======================================
  Hits            ?     3395           
  Misses          ?      830           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hkBst hkBst force-pushed the patch-2 branch 3 times, most recently from ccd1575 to 93551e2 Compare January 3, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant