Allow returning null context pointers from Runtime::get(). #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sagudev
approved these changes
Dec 24, 2024
|
I will make PR to fix integrity today. |
Signed-off-by: Josh Matthews <[email protected]>
jdm
force-pushed
the
optional-runtime-cx
branch
from
2ce8e6e to
f64b290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion fails in various tests and real browser usage, because it's still possible to call this API while shutdown is in progress. Instead of asserting against a valid use, we can use the type system to ensure that callers make informed choices.