Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper to dump the current JS stack. #543

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Add helper to dump the current JS stack. #543

merged 3 commits into from
Dec 25, 2024

Conversation

jdm
Copy link
Member

@jdm jdm commented Dec 20, 2024

This is implemented in C++ due to the use of UniqueChars, which has nontrivial C++ construction/.destruction logic associated with it.

Copy link
Member

@sagudev sagudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs mozjs-sys version bump.

jdm added 2 commits December 25, 2024 02:34
Signed-off-by: Josh Matthews <[email protected]>
@jdm jdm enabled auto-merge December 25, 2024 07:35
@jdm jdm added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit e68fdba Dec 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants