Refactor validateWorkspace
to handle missing custom scalafmtConfigPath
gracefully and log warning
#7080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR refactors the
validateWorkspace
function to gracefully handle missingscalafmtConfigPath
files. Previously, this scenario would result in uncaught exceptions.Example Logs
The refactor:
.toInputFromBuffers
in aTry
to catch errors.scalafmtConfigPath
is missing.None
instead of throwing exceptions, improving stability and providing clear feedback.Key Changes
scalafmtConfigPath
.validateWorkspace
to use a safer text extraction approach.Rationale
Improves robustness and user experience by ensuring the absence of
scalafmtConfigPath
is handled gracefully with logging instead of crashes.Stemmed from discussion in
nvim-metals
(logs included):