bootstrap: drop warning for top-level test suite path check due to false positives #134845
Conversation
This doesn't quite handle the more exotic path suffix matches that test filters seem to accept (e.g. `library/test` can be matched with `--exclude test`), so avoid warning on non-existent top-level test suites for now. A proper fix will need to possibly query test `Step`s for their exclude logic.
|
This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
| let top_level_path = config.src.join(&p); | ||
| if !config.src.join(&top_level_path).exists() { | ||
| eprintln!("WARNING: '{}' does not exist.", top_level_path.display()); | ||
| } |
There was a problem hiding this comment.
Tested this locally with:
./x test test --exclude test
which reports: Skipping Set({test::library/test}) because it is excluded (now without the warning)
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
…zkan bootstrap: drop warning for top-level test suite path check due to false positives The current top-level test suite directory does not exist warning logic doesn't quite handle the more exotic path suffix matches that test filters seem to accept (e.g. `library/test` can be matched with `--exclude test`), so avoid warning on non-existent top-level test suites for now. To avoid false positives, we probably need to query test `Step`s for their `should_run(exclude_filter)` logic. This retains the fix for the Windows path handling (unlike rust-lang#134843). r? `@onur-ozkan`
|
Finished benchmarking commit (8742e05): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 762.432s -> 763.109s (0.09%) |
The current top-level test suite directory does not exist warning logic doesn't quite handle the more exotic path suffix matches that test filters seem to accept (e.g.
library/testcan be matched with--exclude test), so avoid warning on non-existent top-level test suites for now. To avoid false positives, we probably need to query testSteps for theirshould_run(exclude_filter)logic.This retains the fix for the Windows path handling (unlike #134843).
r? @onur-ozkan