Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental] shorten backtraces using debuginfo #134831

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 27, 2024

cc rust-lang/compiler-team#818

r? @ghost

@rustbot label S-experimental

try-job: aarch64-apple

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Dec 27, 2024
@clubby789
Copy link
Contributor

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2024
[experimental] shorten backtraces using debuginfo

cc rust-lang/compiler-team#818

r? `@ghost`

`@rustbot` label S-experimental

try-job: aarch64-apple
@bors
Copy link
Contributor

bors commented Dec 27, 2024

⌛ Trying commit a2beb5e with merge a402123931810f29c74a7fd7ef008dc6e13ed7dd...

@jieyouxu
Copy link
Member

@bors delegate+ (for try jobs)

@bors
Copy link
Contributor

bors commented Dec 27, 2024

✌️ @jyn514, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@rust-log-analyzer

This comment has been minimized.

@jyn514
Copy link
Member Author

jyn514 commented Dec 27, 2024

i think rustc_middle is going to fail to compile, so

@bors cancel try

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
extracting /checkout/obj/build/cache/2024-11-27/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
downloading https://static.rust-lang.org/dist/2024-11-27/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-11-27/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
##[group]Checking stage0 library artifacts {alloc, core, std} (x86_64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
    Updating git repository `https://github.com/jyn514/gimli`
---
    Checking rustc-demangle v0.1.24
    Checking rustc-std-workspace-alloc v1.99.0 (/checkout/library/rustc-std-workspace-alloc)
    Checking panic_unwind v0.0.0 (/checkout/library/panic_unwind)
    Checking panic_abort v0.0.0 (/checkout/library/panic_abort)
    Checking gimli v0.31.1 (https://github.com/jyn514/gimli?branch=shared-attrs#91a5d4e4)
    Checking hashbrown v0.15.2
    Checking std_detect v0.1.5 (/checkout/library/stdarch/crates/std_detect)
    Checking addr2line v0.24.2
    Finished `release` profile [optimized] target(s) in 20.07s

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Updating files:  98% (50003/51023)
Updating files:  99% (50513/51023)
Updating files: 100% (51023/51023)
Updating files: 100% (51023/51023), done.
Switched to a new branch 'try'
branch 'try' set up to track 'origin/try'.
[command]/opt/homebrew/bin/git log -1 --format=%H
a402123931810f29c74a7fd7ef008dc6e13ed7dd
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
[RUSTC-TIMING] compiler_builtins test:false 1.627
   Compiling rustc-std-workspace-alloc v1.99.0 (/Users/runner/work/rust/rust/library/rustc-std-workspace-alloc)
   Compiling panic_abort v0.0.0 (/Users/runner/work/rust/rust/library/panic_abort)
[RUSTC-TIMING] rustc_std_workspace_alloc test:false 0.017
   Compiling gimli v0.31.1 (https://github.com/jyn514/gimli?branch=shared-attrs#91a5d4e4)
   Compiling miniz_oxide v0.7.4
[RUSTC-TIMING] miniz_oxide test:false 0.360
   Compiling std_detect v0.1.5 (/Users/runner/work/rust/rust/library/stdarch/crates/std_detect)
[RUSTC-TIMING] alloc test:false 1.808
---
   Compiling addr2line v0.24.2
[RUSTC-TIMING] addr2line test:false 0.250
[RUSTC-TIMING] gimli test:false 1.848
[RUSTC-TIMING] object test:false 2.529
error[E0502]: cannot borrow `*cx` as immutable because it is also borrowed as mutable
    |
    |
495 |             if let Some((object_cx, object_addr)) = cx.object.search_object_map(addr as u64) {
    |                                                     --------- mutable borrow occurs here
496 |                 if let Ok(mut frames) = object_cx.find_frames(stash, object_addr) {
497 |                     while let Ok(Some(frame)) = frames.next() {
    |                                                 ------ mutable borrow later used here
...
501 |                             short_backtrace: parse_short_backtrace(cx, stash, addr as u64, &frame),
    |                                                                    ^^ immutable borrow occurs here
For more information about this error, try `rustc --explain E0502`.
[RUSTC-TIMING] std test:false 1.610
error: could not compile `std` (lib) due to 1 previous error
Build completed unsuccessfully in 0:54:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants