Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin::on_call: Add basic send() tests #3121

Closed
wants to merge 1 commit into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 25, 2020

This PR adds a few basic tests for the Event::send() functionality. It introduces the mockito crate for HTTP mocking, which appears to be easier to use than the custom HTTP proxy setup that we seem to be using in a few other tests.

r? @jtgeibel

@bors
Copy link
Contributor

bors commented Dec 28, 2020

☔ The latest upstream changes (presumably #3115) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the httpmock branch 3 times, most recently from 85a5257 to be6bb97 Compare December 30, 2020 16:50
@bors
Copy link
Contributor

bors commented Dec 31, 2020

☔ The latest upstream changes (presumably #3149) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the httpmock branch 3 times, most recently from 030097d to 0eeeea1 Compare January 7, 2021 01:20
@Turbo87 Turbo87 linked an issue Jan 7, 2021 that may be closed by this pull request
9 tasks
@bors
Copy link
Contributor

bors commented Jan 14, 2021

☔ The latest upstream changes (presumably #3117) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jan 15, 2021

☔ The latest upstream changes (presumably #3182) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the httpmock branch 2 times, most recently from e3b0e85 to 0f7c989 Compare January 19, 2021 18:37
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Feb 11, 2021
@bors
Copy link
Contributor

bors commented Apr 27, 2021

☔ The latest upstream changes (presumably #3564) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 closed this Jun 6, 2021
@Turbo87 Turbo87 deleted the httpmock branch October 17, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants