Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regularization #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RainerHeintzmann
Copy link
Contributor

modified TV to be able to work without needing to specify the dimension number and whether the array is a CuArray or not.

@roflmaostc
Copy link
Owner

Thanks!

However, the CPU regularizer are more powerful than the CUDA regularizer.
Hence, sharing the same interface is misleading.

In the long term, I was hoping that Tullio.jl catches up and might perform equally well with CUDA as the Julia default functions.

@RainerHeintzmann
Copy link
Contributor Author

Are you referring to the sum_dims and the step argument? I guess they can also be realized in the sub-index (cuda) version. The same should hold for the forward but this is anyways not an interesting choice apart from trying something out.
I think the damage that is done by throwing a hard to understand error when trying a regularizer straight away with CuArrays is far bigger.

@roflmaostc
Copy link
Owner

I agree, but it is clearly mentioned in the documentation and examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants