Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take 2: Upgrade to react-router@7, eslint@9, version bump the rest #102

Merged
merged 20 commits into from
Dec 28, 2024

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Dec 28, 2024

Had to revert #101 because it wasn't starting up correctly; the built artifact did not include the actual express startup code. This PR copies in the startup script via Docker because of how the React Router v7 "framework mode" build tool functions. #101 has the original motivation for the change.

Copy link

what-the-diff bot commented Dec 28, 2024

PR Summary

  • Refinement of ESLint and Git Configurations: ESLint set-up files have been removed. The .gitignore file has been updated to not account for Cypress and .react-router.

  • Optimizing Husky and Lint-Staged Configurations: Updates to our Husky pre-push hook and lint-staged configurations enhance code validation processes.

  • Dockerfile, React and Message Handlers Adjustments: Updated copy commands within Dockerfile and refactored the entry point for React hydration, ensuring better TypeScript safety.

  • Imports and TypeScript Definitions Improvements: Standardized and updated various types and import lines across the project to ensure better compatibility and type safety.

  • Command Comparison Simplified: The logic in the comparison of commands was cleaned up, thereby facilitating easier remote and local options handling.

  • Removal of Unused Files and Code: Certain unused files and functions have been removed, streamlining the codebase.

  • Better Session Handling and Data Management: Enhanced session handling and server response structures, which would make error handling more robust and consistent.

  • Introduction of New Routing and Server Setups: A new route configuration and an Express server setup have been implemented, averting manual configurations and adopting a structured setup.

  • Refining Component and CSS Imports: Improvements in component imports, exports, and CSS import method to ensure better readability and straightforwardness in code structure.

  • Enhancements in Stylesheet and Testing Set-up: Significant update to tailwind.css and the removal of several Cypress files, indicating a shift towards another testing approach.

  • Addition of ESLint Configuration and Server Entry Points: New ESLint settings for linting and separate entry points for production and development are included now.

  • Environment Variables and Configuration Files Update: Environment checks, deletion of mock-related files, and updates to various configuration files have been carried out to support application consistency and the use of modern libraries.

These changes are aimed at enhancing the overall efficiency, readability, and maintainability of the project by using improved libraries and tools, eliminating redundant code, and refining both server-side and client-side functionalities.

@vcarl vcarl marked this pull request as ready for review December 28, 2024 08:15
@vcarl
Copy link
Member Author

vcarl commented Dec 28, 2024

the removal of several Cypress files, indicating a shift towards another testing approach.

bold of you to assume

@vcarl vcarl merged commit cc16c6d into main Dec 28, 2024
5 checks passed
@vcarl vcarl deleted the vc-deps-update branch December 28, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant