Add config option for Discord setActivity #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekmartin
reviewed
Jul 25, 2018
| @@ -90,6 +90,8 @@ First you need to create a Discord bot user, which you can do by following the i | |||
| "irc": ["irc_nick1", "irc_nick2"], // Ignore specified IRC nicks and do not send their messages to Discord. | |||
| "discord": ["discord_nick1", "discord_nick2"] // Ignore specified Discord nicks and do not send their messages to IRC. | |||
| }, | |||
| // Sets the discord activity status, can be set to one of "PLAYING, STREAMING, LISTENING or WATCHING" | |||
| "discordStatus": ["PLAYING", "with you!"], | |||
There was a problem hiding this comment.
Maybe it would be more self explantory if this was an object? E.g. something like:
"discordStatus": {
"name": ...,
"type": ...,
"url": ...
}
|
I can't tell what's going on between #423, #368 and #359. Are there any plans to change the PR further, and would you be able to add (basic) tests for the functionality? (Is there consensus on a specific implementation?) I don't care much about the rich presence system, so something that people agree works would be good. |
This was referenced Aug 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another alternative to resolve issue #246
I chose to use the setActivity class as in my opinion, makes more sense for something like this.