Best practice for fault-tolerant redis with kuberay #2684
Conversation
There was a problem hiding this comment.
Currently, we add the KubeRay documentation to the Ray repository so that it will automatically appear on the Ray website at https://docs.ray.io/en/latest/cluster/kubernetes/user-guides.html. Would you mind opening a PR to the Ray repository for the documentation and leaving this PR only for the YAML?
|
Then, you can cc @rueian and me to review. Thanks! |
|
|
||
| Specialty storage volumes (like Google Cloud Storage FUSE or S3) are not | ||
| recommended because append operations are not supported, which Redis uses to | ||
| efficiently write its Append Only File (AOF) log. |
There was a problem hiding this comment.
Instead of not recommending these cloud storage, can we say we recommend disabling AOF when backed by these cloud storages?
| You can view the full reference for 5.0.8 | ||
| [here](https://raw.githubusercontent.com/redis/redis/refs/tags/5.0.8/redis.conf). |
There was a problem hiding this comment.
I think 5.0.8 is a bit too old.
| You can view the full reference for 5.0.8 | |
| [here](https://raw.githubusercontent.com/redis/redis/refs/tags/5.0.8/redis.conf). | |
| You can view the full reference for 7.4.0 | |
| [here](https://raw.githubusercontent.com/redis/redis/refs/tags/7.4.0/redis.conf). |
| resources: | ||
| requests: | ||
| storage: 8Gi | ||
| storageClassName: standard-rwo |
There was a problem hiding this comment.
| storageClassName: standard-rwo | |
| # choose a storageClassName provided by your Kubernetes: | |
| # storageClassName: standard-rwo |
Since standard-rwo may not work out of the box, can we comment out this line but leave a note to ask users to choose an available storageClassName provided by their k8s?
|
Hi @spencer-p, LGTM mostly. Thanks for the nice doc. |
Why are these changes needed?
Addresses #2582
Related issue number
Closes #2582
Checks