-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda-forge channel support #198
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR,
Any idea if tkinter should be a requirement as it does not come installed with all python installations? such as on pop os
Also I think this is correct? pypi https://pypi.org/project/tksheet/#files is showing the sha256 hash to be as below
{% set name = "tksheet" %}
{% set version = "6.2.3" %}
package:
name: {{ name|lower }}
version: {{ version }}
source:
url: https://github.com/ragardner/tksheet/archive/{{ version }}.tar.gz
sha256: b97b5fd85cfc878a5d64cc38877c6031df21788ed1702bc7a35b26304d026f6c
build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv
number: 0
requirements:
host:
- python >=3.6
- pip
run:
- python >=3.6
test:
imports:
- tksheet
commands:
- pip check
requires:
- pip
about:
home: https://github.com/ragardner/tksheet
license: MIT
license_file: LICENSE.txt
extra:
recipe-maintainers:
- ragardner
I got the sha256 change done. I also added tk as a requirement. I added a few other fields that previously have been requested when adding packages to conda-forge. Also, I'm happy to do the steps from that link to get tksheet on conda-forge if you'd prefer. |
Thanks a lot, I am sorry to mess you around a bit but, I remembered sorry that the reason the hashes might be different is the zipped files are different on pypi here: compared to github here: I think when you use the command pip install tksheet it uses the pypi link e.g. because it would have the files generated by I'm not sure which link would be appropriate to use I have given a bit of thought to who should add it to conda-forge, I think given your requirement it might be better if you forked tksheet and did it, I might not be around to support it on conda if you need it modified I am open to suggestions though |
No problem. The SHA256 question is also unclear to me... I did try to run Yes, I'm happy to take care of getting it on conda-forge—no worries on that front. I'm also doing this for another package that I need support for. |
Sorry for the long delay but if you haven't already, yes you can go ahead and put it on conda forge if you want |
Hello,
I'm developing a package that tksheet is a dependency of. I want to put it on conda-forge, but that means all my package's dependencies must also be on conda-forge. This PR has the meta.yaml file needed. Here is the guide for adding to conda-forge: https://conda-forge.org/docs/maintainer/adding_pkgs.html.