Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON file linter #6893

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Dec 29, 2024

This adds check/jsonlint and a corresponding configuration file .jsonlintrc.yaml. Running ./check/jsonlint will check all .json files recursively from the top of the source tree, ignoring subdirectories like .mypy_cache that might contain files that should be ignored for purposes of linting JSON files.

This adds `check/jsonlint` and a corresponding configuration file
`.jsonlintrc.yaml`. Running `./check/jsonlint` will check all `.json`
files recursively from the top of the source tree, ignoring
subdirectories like `.mypy_cache` that might contain files that should
be ignored for purposes of linting JSON files.
@CirqBot CirqBot added the size: S 10< lines changed <50 label Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (06f12b9) to head (ceea3bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6893      +/-   ##
==========================================
- Coverage   97.86%   97.86%   -0.01%     
==========================================
  Files        1084     1084              
  Lines       94225    94225              
==========================================
- Hits        92215    92214       -1     
- Misses       2010     2011       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Just to be slightly more consistent with other scripts.
@mhucka mhucka marked this pull request as ready for review December 30, 2024 05:16
@mhucka mhucka requested review from vtomole and a team as code owners December 30, 2024 05:16
@mhucka mhucka requested a review from senecameeks December 30, 2024 05:16
@mhucka mhucka added the kind/health For CI/testing/release process/refactoring/technical debt items label Dec 31, 2024
@mhucka mhucka self-assigned this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/health For CI/testing/release process/refactoring/technical debt items size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants