Refactor engine client test_create_job test names for better clarity and consistency
#6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayshiff
requested review from
wcourtney,
vtomole,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6885 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1084 1084
Lines 94225 94321 +96
=======================================
+ Hits 92215 92311 +96
Misses 2010 2010 ☔ View full report in Codecov by Sentry. |
Split initial test_create_job into: - Four successful tests: - test_create_job_with_all_parameters - test_create_job_without_labels - test_create_job_without_description - test_create_job_without_specified_job_id - One failure test: - test_create_job_with_invalid_priority Note: Splitting successful tests to stay consistent with existing tests: - test_create_job_with_invalid_processor_and_device_config_arguments_throws - test_create_job_with_run_name_and_device_config_name_succeeds
ayshiff
force-pushed
the
improve-test-create-job-names
branch
from
34fbebd to
eddb152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split initial
test_create_jobtest into:test_create_job_with_all_parameterstest_create_job_without_labelstest_create_job_without_descriptiontest_create_job_without_specified_job_idtest_create_job_with_invalid_priorityNote: Splitting successful tests to stay consistent with existing tests:
test_create_job_with_invalid_processor_and_device_config_arguments_throwstest_create_job_with_run_name_and_device_config_name_succeedsFixes #6761