Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return NotImplemented for diagram info for empty PauliStringPhasors #6880

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Dec 24, 2024

This fixes problems created when diagramming a PauliSumExponential on an I, which gets stripped out.

Fixes #5944

This fixes problems created when diagramming a PauliSumExponential on an `I`, which gets stripped out.
@daxfohl daxfohl requested review from vtomole and a team as code owners December 24, 2024 14:05
@daxfohl daxfohl requested a review from dstrain115 December 24, 2024 14:05
@CirqBot CirqBot added the Size: XS <10 lines changed label Dec 24, 2024
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (06f12b9) to head (510398e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6880   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1084     1084           
  Lines       94225    94290   +65     
=======================================
+ Hits        92215    92280   +65     
  Misses       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhucka mhucka enabled auto-merge (squash) January 2, 2025 03:39
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mhucka mhucka merged commit 4ad58f6 into quantumlib:main Jan 2, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot print PauliSumExponential of identity gate
3 participants