Removed wrong saving of layout #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for grid-layout-plus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@filippo-biondi does this fix the overlaps when using At least in the deployed netlify version it doesn't seem so. 
|
|
Yes you're correct. Probably my fix solved only the specific issue I was having on my project. I think the root cause of the overlapping is the implementation of findOrGenerateResponsiveLayout. |
|
@filippo-biondi I bypassed this by making my own items positioning logic based on columns size, but Ideally I think it should be fixed in the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a saving of layout in responsiveGridLayout(). The saving was happening before findOrGenerateResponsiveLayout and this caused the originalLayout to be saved as layout for the current breakpoint. This caused some plots to overlap if the number of column in the originalLayout was bigger than the number of columns allowed by the current breakpoint. Furthermore the layout is correctly saved after findOrGenerateResponsiveLayout so I think the efficency is unaltered