Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Wheel naming is not following PEP 491 convention" #4766

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

di
Copy link
Member

@di di commented Dec 10, 2024

Summary of changes

Fixes #3777.

Marking this as draft as there is one outstanding failing test that I have been unable to resolve (setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg).

Pull Request Checklist

@abravalheri
Copy link
Contributor

Thank you!

The failing test seems to be happening now regardless of this change: https://github.com/pypa/setuptools/actions/runs/12298183072/job/34321035714#step:3:49.

I don't know if anything changed in the latest versions of Python being distributed to macOS, so that __file__ is no longer available on the scope.

@di
Copy link
Member Author

di commented Dec 12, 2024

Aha, that's a different failure actually, setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg is the test that is legitimately failing and would need to be updated here.

@abravalheri
Copy link
Contributor

setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg is the test that is legitimately failing and would need to be updated here.

This looks like it is checking deprecated functionality? Not sure we have to account such an edge case since we are moving away from easy_install. Maybe we can do a major bump to show that the change may be considered a breaking change.

@di
Copy link
Member Author

di commented Dec 12, 2024

I'm not sure! I think the test is just broken in a way I haven't been able to figure out (it mixes the distribution name and the namespace name as one thing in the helper functions) but I think the underlying functionality probably still works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wheel naming is not following PEP 491 convention
2 participants