Enforce ruff/refurb rules (FURB) #4386
Open
+39
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
FURB
branch
4 times, most recently
from
39e788a to
c6d0727
Compare
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
7aae70f to
15952e9
Compare
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
FURB
branch
2 times, most recently
from
44c33c5 to
6b2b9ac
Compare
DimitriPapadopoulos
force-pushed
the
FURB
branch
2 times, most recently
from
a563475 to
3477d01
Compare
|
Looks like you're missing imports for |
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
3477d01 to
ac0302c
Compare
|
I think I mistakenly removed the |
DimitriPapadopoulos
force-pushed
the
FURB
branch
3 times, most recently
from
e15d1e9 to
e117139
Compare
DimitriPapadopoulos
force-pushed
the
FURB
branch
2 times, most recently
from
80f3b0d to
b03c668
Compare
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
b03c668 to
7fa561c
Compare
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
7fa561c to
82c0acc
Compare
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
82c0acc to
9ddb5e8
Compare
Avasam
reviewed
Dec 30, 2024
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
9ddb5e8 to
33bba92
Compare
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
33bba92 to
2b4de4f
Compare
FURB110 Replace ternary `if` expression with `or` operator
FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
FURB142 Use of `set.add()` in a for loop
FURB167 Use of regular expression alias `re.I` FURB167 Use of regular expression alias `re.M` FURB167 Use of regular expression alias `re.S` FURB167 Use of regular expression alias `re.X`
FURB188 Prefer `removesuffix` over conditionally replacing with slice.
FURB192 Prefer `max` over `sorted()` to compute the maximum value in a sequence
DimitriPapadopoulos
force-pushed
the
FURB
branch
2 times, most recently
from
bf51fe7 to
282cc26
Compare
DimitriPapadopoulos
changed the title
Co-authored-by: Avasam <[email protected]>
2 tasks
|
@DimitriPapadopoulos I think you're missing a |
|
Now that this is back to being a simpler PR. @abravalheri / @jaraco refurb would also have been one of my suggestions with improvements in readability and simplifications. |
Avasam
reviewed
Jan 3, 2025
Co-authored-by: Avasam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Follow-up of #4172.
Pull Request Checklist
newsfragments/.(See documentation for details)