Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docs about version_scheme and local_scheme #1094

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 3, 2025

I added cross-references to the implementations. it was confusing to me before that the available options weren't listed in config.md. See comments in individual commits for more details.

maresb added 4 commits January 3, 2025 18:42
I had a difficult time finding the implementations in the docs, despite knowing of their existence. Adding this cross-reference should help.

x
In PEP 440, "local" refers to the optional portion of a version after the `+` <https://peps.python.org/pep-0440/#local-version-identifiers>. But `version_scheme` doesn't apply to this part.
Most people reading this sentence probably don't have PEP 440 memorized.
@maresb maresb changed the title Improve the docs about version_scheme and local_scheme. Improve the docs about version_scheme and local_scheme Jan 3, 2025
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RonnyPfannschmidt RonnyPfannschmidt merged commit 5d3a1f8 into pypa:main Jan 4, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants