feat: Add iTunes Store Identifier to metadata #2478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR description
iTunesStoreIdentifier
toFeatureName
inpyatv/const.py
.Playing
class inpyatv/interface.py
to includeitunes_store_identifier
.metadata_field
function inpyatv/protocols/mrp/__init__.py
to supportitunes_store_identifier
.tests/fake_device/mrp.py
to handleitunes_store_identifier
.tests/protocols/mrp/test_mrp_functional.py
to verifyitunes_store_identifier
.itunes_store_identifier
.Honestly first time really working in a mature python codebase so hopefully this checks all the boxes. I tried to follow the guidelines. But am leaning on this portion of the MD file lol
The tool Im building was really hinging on the ability to identify the content from the Apple TV App, but seemed like they only supplied the Title (which was just the series name if it was a tv show, not even the episode name. You would think apple would be better at implementing their own interfaces but I digress 😆) . But with some debugging I saw that iTunesStoreIdentifier was typically available for the Apple TV App so I exposed that the the Playing interface.
Im currently using a local version with these changes for what im building but wanted to at least submit a PR if it proved useful for someone else.