feat!: React 19 support #2349
Draft
feat!: React 19 support #2349
+187
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodyJasonBennett
commented
Jan 2, 2025
Comment on lines
21
to
23
| const host = createHost(primitives, { | ||
| // @ts-expect-error r3f related | ||
| applyAnimatedValues: applyProps, | ||
| }) |
There was a problem hiding this comment.
This should probably be a proxy since it is valid to extend the JSX interface beyond what the THREE namespace contains.
5 tasks
This used to be pulled in by R3F, but we vendor it upstream as of late. Even though we intend to later migrate changes, it's best to not depend on transient dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adds support for React 19 and R3F v9.
What
Upstream breaking changes are limited to types, and I opt to remove deprecated patterns where able:
MutableRefObject<T>->RefObject<T>useRef<T>()->useRef<T>(null)JSX->React.JSXPropsWithRef<T>->TJSX.IntrinsicElements->ThreeElements(see review comment)Checklist