Fix nodevault#175, handle trailing slash on endpoint

Co-authored-by: Jason Nguyen <[email protected]> Co-authored-by: Bret Hubbard <[email protected]
pluralsight · Jan 5, 2021 · e97f19b · e97f19b
1 parent 7009726
commit e97f19b
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -71,6 +71,8 @@ module.exports = (config = {}) => {
   client.noCustomHTTPVerbs = config.noCustomHTTPVerbs || false;
   client.namespace = config.namespace || process.env.VAULT_NAMESPACE;
 
+  client.endpoint = client.endpoint.replace(/\/$/, '');
+
   const requestSchema = {
     type: 'object',
     properties: {

diff --git a/test/unit.js b/test/unit.js
@@ -87,6 +87,31 @@ describe('node-vault', () => {
     });
   });
 
+  describe('client initialization', () => {
+    it('should not trim endpoint if no trailing slash', () => {
+      const defaultsStub = sinon.stub();
+      const vaultConfig = {
+        endpoint: 'http://localhost:8200',
+        'request-promise': {
+          defaults: defaultsStub,
+        },
+      };
+      const vault = index(vaultConfig);
+      vault.endpoint.should.equal('http://localhost:8200');
+    });
+
+    it('should trim endpoint if trailing slash', () => {
+      const defaultsStub = sinon.stub();
+      const vaultConfig = {
+        endpoint: 'http://localhost:8200/',
+        'request-promise': {
+          defaults: defaultsStub,
+        },
+      };
+      const vault = index(vaultConfig);
+      vault.endpoint.should.equal('http://localhost:8200');
+    });
+  });
 
   describe('client', () => {
     let request = null;