Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOF - near blur is optional #7220

Merged
merged 3 commits into from
Dec 20, 2024
Merged

DOF - near blur is optional #7220

merged 3 commits into from
Dec 20, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Dec 20, 2024 •
edited
Loading

  • made the near blur optional, to allow cheaper DOF when only the far blur is needed
  • skips blurring the near part of the texture
  • CoC texture is single channel instead of two channel

new public API:

CameraFrame.dof.nearBlur  // defaults to false

@mvaligursky mvaligursky mentioned this pull request Dec 20, 2024
Open
9 tasks
@mvaligursky mvaligursky self-assigned this Dec 20, 2024
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Dec 20, 2024
@mvaligursky mvaligursky requested a review from a team December 20, 2024 12:17
slimbuck
slimbuck approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it should be default off, but if doom does it that way...

Merge branch 'main' into mv-dof-nearblur
89b47e4 
# Conflicts:
#	src/extras/render-passes/render-pass-dof-blur.js
@mvaligursky mvaligursky merged commit d0318ba into main Dec 20, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-dof-nearblur branch December 20, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck