makefile: update build cmd in graceshutdown & globalkilltest makefile #47704

purelind · 2023-10-17T06:12:01Z

What problem does this PR solve?

Issue Number: close #47705

Problem Summary:
Relate to #47123, we need to update build cmds to modify tidb-server src path.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: purelind <[email protected]>

tiprow · 2023-10-17T06:12:24Z

Hi @purelind. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-10-17T06:20:37Z

Codecov Report

Merging #47704 (5b88d5b) into master (91a8023) will increase coverage by 1.3493%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47704        +/-   ##
================================================
+ Coverage   71.8856%   73.2349%   +1.3492%     
================================================
  Files          1398       1421        +23     
  Lines        405057     417986     +12929     
================================================
+ Hits         291178     306112     +14934     
+ Misses        94273      92760      -1513     
+ Partials      19606      19114       -492

Flag	Coverage Δ
integration	`41.7960% <ø> (?)`
unit	`72.4062% <ø> (+0.5205%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`49.2411% <ø> (-3.7401%)`	⬇️

purelind · 2023-10-17T06:24:22Z

/test ?

ti-chi-bot · 2023-10-17T06:24:25Z

@purelind: The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

purelind · 2023-10-17T06:24:39Z

/test pull-e2e-test

tiprow · 2023-10-17T06:24:55Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-10-17T06:25:12Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

purelind · 2023-10-17T06:25:14Z

/cc @bb7133 @pingyu

pingyu

LGTM~

purelind · 2023-10-17T06:36:37Z

/test pull-e2e-test

tiprow · 2023-10-17T06:37:08Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: purelind <[email protected]>

purelind · 2023-10-17T06:38:11Z

/test pull-e2e-test

tiprow · 2023-10-17T06:38:48Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

purelind · 2023-10-17T06:51:20Z

/test pull-e2e-test

tiprow · 2023-10-17T06:51:54Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

purelind · 2023-10-17T07:36:54Z

e2e-test failed with error log, This seems to be an unstable test, unrelated to the current PR. The error will be fixed in another PR.

--- FAIL: TestConnIDUpgradeAndDowngrade (20.94s)
    global_kill_test.go:116: 
        	Error Trace:	/home/jenkins/agent/workspace/pingcap/tidb/pull_e2e_test/tidb/tests/globalkilltest/global_kill_test.go:116
			/home/jenkins/agent/workspace/pingcap/tidb/pull_e2e_test/tidb/tests/globalkilltest/global_kill_test.go:830
        	Error:      	"161480738" is not greater than "4294967296"
        	Test:       	TestConnIDUpgradeAndDowngrade
        	Messages:   	connID 9a00022
FAIL
exit status 1
FAIL	github.com/pingcap/tidb/tests/globalkilltest	375.488s
script returned exit code 1

bb7133

LGTM

ti-chi-bot · 2023-10-17T08:02:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, pingyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bb7133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-10-17T08:02:15Z

[LGTM Timeline notifier]

Timeline:

2023-10-17 06:29:45.523657423 +0000 UTC m=+1724983.110767567: ☑️ agreed by pingyu.
2023-10-17 08:02:14.153826807 +0000 UTC m=+1730531.740936952: ☑️ agreed by bb7133.

purelind · 2023-10-17T08:03:25Z

/retest

tiprow · 2023-10-17T08:04:10Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-10-17T08:20:53Z

@purelind: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
wip/pull-e2e-test	`5b88d5b`	link	true	`/test pull-e2e-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot · 2023-10-17T09:11:42Z

In response to a cherrypick label: new pull request created to branch release-7.5: #47717.

…#47704) (#47717) close #47705

…pingcap#47704) close pingcap#47705

fix: update build cmd in makefile

ca20218

Signed-off-by: purelind <[email protected]>

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023

ti-chi-bot bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Oct 17, 2023

ti-chi-bot bot requested review from bb7133 and pingyu October 17, 2023 06:25

pingyu approved these changes Oct 17, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 17, 2023

purelind changed the title ~~makefile: update build cmd in graceshutdown makefile~~ makefile: update build cmd in graceshutdown & globalkilltest makefile Oct 17, 2023

ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Oct 17, 2023

fix: update build cmd in makefile

5b88d5b

Signed-off-by: purelind <[email protected]>

bb7133 approved these changes Oct 17, 2023

View reviewed changes

ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023

ti-chi-bot bot merged commit d818a00 into pingcap:master Oct 17, 2023

ti-chi-bot mentioned this pull request Oct 17, 2023

makefile: update build cmd in graceshutdown & globalkilltest makefile (#47704) #47717

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023

makefile: update build cmd in graceshutdown & globalkilltest makefile (…

2d036e4

…#47704) (#47717) close #47705

wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024

makefile: update build cmd in graceshutdown & globalkilltest makefile (…

a52904a

…pingcap#47704) close pingcap#47705

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

makefile: update build cmd in graceshutdown & globalkilltest makefile #47704

makefile: update build cmd in graceshutdown & globalkilltest makefile #47704

purelind commented Oct 17, 2023 •

edited

Loading

tiprow bot commented Oct 17, 2023

codecov bot commented Oct 17, 2023 •

edited

Loading

purelind commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

pingyu left a comment

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

bb7133 left a comment

ti-chi-bot bot commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

ti-chi-bot commented Oct 17, 2023

makefile: update build cmd in graceshutdown & globalkilltest makefile #47704

makefile: update build cmd in graceshutdown & globalkilltest makefile #47704

Conversation

purelind commented Oct 17, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Oct 17, 2023

codecov bot commented Oct 17, 2023 • edited Loading

Codecov Report

purelind commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

pingyu left a comment

Choose a reason for hiding this comment

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

purelind commented Oct 17, 2023

bb7133 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

purelind commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

ti-chi-bot commented Oct 17, 2023

purelind commented Oct 17, 2023 •

edited

Loading

codecov bot commented Oct 17, 2023 •

edited

Loading