Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spidertools): Added support for optional API parameters and setting default crawl limit #1649

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gbertb
Copy link

@gbertb gbertb commented Dec 27, 2024

Hi, member of Spider team here, would love to add these changes to the tool.

Description

  • Summary of changes: Updated tool to allow passing in custom params when instantiating SpiderTools class. Added a default limit of 10 for crawling, to reduce token waste.

  • Motivation and context: Allowing custom parameters to be passed allows the developer to handle more use cases or control the scraping ability of a given URL (e.g. turning on proxy etc).

  • Environment or dependencies: No changes in dependencies or environment configurations required for this update.

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

Copy link
Contributor

@ysolanky ysolanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates @gbertb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants