Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qdrant default embedder #1643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix qdrant default embedder #1643

wants to merge 1 commit into from

Conversation

ysolanky
Copy link
Contributor

@ysolanky ysolanky commented Dec 26, 2024

Description

Removes OpenAI embedder as the default embedder for Qdrant

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

@DarkDk123
Copy link

Hey @ysolanky,
I am new to open source contributions & wanna learn.

Upon seeing your Merge Request, i cannot understand why you're moving OpenAIEmbedder from default argument to the constructor body? isn't it same!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants