Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: passing down ssl verification as it's available in DDGS class #1604

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FaresKi
Copy link

@FaresKi FaresKi commented Dec 19, 2024

Description

Please include:

  • Summary of changes: DDGS provides SSL verification option (with verification enabled by default). Adding it to the DuckDuckGo tool also.
  • Related issues: N/A
  • Motivation and context: Experimenting with the introduction example, and ran into SSL issues (cough cough enterprise stuff cough cough)
  • Environment or dependencies: No changes.
  • Impact on AI/ML components: (If applicable) N/A

Fixes # N/A

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

Additional Notes

Include any deployment notes, performance implications, or other relevant information: When trying to format, according to the CONTRIBUTING.md, the ruff module wasn't installed by default using the create venv script. I can see it's in the dev modules inside the pyproject.toml. Is that expected? Thanks!

@@ -33,6 +34,8 @@ def __init__(
if news:
self.register(self.duckduckgo_news)

self.verify: bool = verify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better param would be verify_ssl. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Will change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants