Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'ci' command alias equivalent to 'install --frozen-lockfile' #16137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mchv
Copy link

@mchv mchv commented Jan 3, 2025

What does this PR do?

This adds a new command ci similar to npm ci which is an alias for install --frozen-lockfile. The associated changes try to limit new code to handle this alias, I have added specific comments below.

fixes #5283

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I wrote one automated test

  • I tested locally

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be

  • I included a test for the new code, or an existing test covers it

  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed

  • I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)

return this.next() != null;
}
};

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ArgsIterator struct comes from cli file and maybe it should be extracted to be reused instead of copied but it is the first copy and code is pretty simple so I don't know if it is worth yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun ci as an alias of bun install --frozen-lockfile
1 participant