Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bindgen): check for corresponding .zig file #15896

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Dec 20, 2024

When generating bindings for foo.bind.ts, ensure a foo.zig file exists next to it. Builds will fail downstream if this is missing, this error just makes it surface sooner and in a more clear manner.

@DonIsaac DonIsaac added the build An issue related to building or compiling label Dec 20, 2024
@DonIsaac DonIsaac requested a review from paperdave December 20, 2024 05:53
@robobun
Copy link

robobun commented Dec 20, 2024

Updated 7:21 PM PT - Dec 27th, 2024

@DonIsaac, your commit 8e4d101 has 1 failures in #8611:


🧪   try this PR locally:

bunx bun-pr 15896

Copy link
Member

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding the additional assertion

src/codegen/bindgen-lib.ts Outdated Show resolved Hide resolved
@DonIsaac DonIsaac enabled auto-merge December 23, 2024 16:28
@DonIsaac DonIsaac added this pull request to the merge queue Dec 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2024
@DonIsaac DonIsaac enabled auto-merge December 28, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build An issue related to building or compiling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants