Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Result node may uses inputs names on creation #28168

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[core] Result node may uses inputs names on creation #28168

wants to merge 3 commits into from
+76 −18

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Dec 20, 2024 •
edited
Loading

Details:

  • The Result node may use inputs names when created. Creation such Result assume as previous layer is model output.
  • The model when created from outputs and the outputs are note Result node, then create results and take its names as model output names.
  • The Result has option to enable/disable use inputs names as it owns. If names not used they still be visible as output names if Result has no dedicated names but if Result is connect to other input these names stay on origin input.

Tickets:

@praasz praasz requested review from a team as code owners December 20, 2024 12:41
@praasz praasz requested review from itikhono and removed request for a team December 20, 2024 12:41
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: Core OpenVINO Core (aka ngraph) category: transformations OpenVINO Runtime library - Transformations category: IR FE OpenVINO IR v10 / v11 FrontEnd category: ONNX FE OpenVINO ONNX FrontEnd category: CPP API OpenVINO CPP API bindings labels Dec 20, 2024
@github-actions github-actions bot removed the category: inference OpenVINO Runtime library - Inference label Dec 20, 2024
@praasz praasz changed the title [core] Result node uses inputs names on creation [core] Result node may uses inputs names on creation Dec 21, 2024
@praasz praasz added this to the 2025.0 milestone Dec 21, 2024
@StefaniaHergane
Copy link
Contributor

Tests look good in NPU CI

ilya-lavrenov
ilya-lavrenov reviewed Dec 24, 2024
View reviewed changes
src/core/src/node_vector.cpp
@@ -29,7 +29,7 @@ ov::ResultVector ov::as_result_vector(const OutputVector& values) {
for (const auto& value : values) {
std::shared_ptr<Node> node = value.get_node_shared_ptr();
result.push_back(ov::is_type<ov::op::v0::Result>(node) ? ov::as_type_ptr<ov::op::v0::Result>(node)
: std::make_shared<ov::op::v0::Result>(value));
: std::make_shared<ov::op::v0::Result>(value, true));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you also fix ov::Model::add_output ?

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Dec 24, 2024
@ilya-lavrenov ilya-lavrenov removed this pull request from the merge queue due to a manual request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@razvanapetroaie razvanapetroaie razvanapetroaie approved these changes

@StefaniaHergane StefaniaHergane StefaniaHergane approved these changes

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

Assignees

@itikhono itikhono

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IR FE OpenVINO IR v10 / v11 FrontEnd category: ONNX FE OpenVINO ONNX FrontEnd category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
5 participants
@praasz @StefaniaHergane @ilya-lavrenov @razvanapetroaie @itikhono